search

sebastiencs / company-box

A company front-end with icons
563 stars 64 forks source link

Fixed breaking changes after company-mode update #168

Closed CsBigDataHub closed 3 years ago

CsBigDataHub commented 3 years ago

fixes https://github.com/sebastiencs/company-box/issues/167

company-mode updated functions

seagle0128 commented 3 years ago

ping @sebastiencs ...

It's a critical fix.Please merge it ASAP. Thanks!

sebastiencs commented 3 years ago

Merged, thanks @CsBigDataHub @seagle0128

CsBigDataHub commented 3 years ago

Thanks @sebastiencs .

Now the numbering is off, when show-numbers is enabled.

image

I suspect these line is the culprit -

https://github.com/sebastiencs/company-box/blob/c8a867163b15586cc9ed4accb992094308e54a9a/company-box.el#L293

or

https://github.com/sebastiencs/company-box/blob/c8a867163b15586cc9ed4accb992094308e54a9a/company-box.el#L411

dgutov commented 3 years ago

Try removing (+1 from the first one.

CsBigDataHub commented 3 years ago

@dgutov thanks Created a PR #169

@sebastiencs please push it whenever you can.

seagle0128 commented 3 years ago

Another thing is company-box numbers should respect company-tooltip-quick-access face.