search

sebastiencs / company-box

A company front-end with icons
563 stars 64 forks source link

Update frame's background #172

Open iris-garcia opened 3 years ago

iris-garcia commented 3 years ago

Fixes #148.

jthaman commented 2 years ago

I'd love to see this merged.

sebastiencs commented 1 year ago

Hi @iris-garcia , thanks for your PR !

The call to company-box--update-frame-background is a bit expensive and I would prefer to avoid it on every run of company-box--display.

In https://github.com/sebastiencs/company-box/commit/82c1a30e152f403089a2f2e98769a61bc1afc56d I made an alternate solution: it will delete the frames (of company-box) every time the theme is changing. This will force to use the colors of the new theme.

Could you, or @jthaman , confirm that it works ?

Thanks !