Make the frame's top position user configurable.

sebastiencs / company-box

A company front-end with icons

563 stars 64 forks source link

Closed gyst closed 5 months ago

gyst commented 7 months ago

This is my first lisp PR, so please be gentle ;-).

I'm using company-box together with copilot. I need to push the top of the company box frame down, so that the company box frame does not mask the first lines of copilot suggestions.
Even without copilot, using company-box on a base text with enlarged fonts benefits from adding extra vertical space

Without extra top margin:

With extra top margin set to 70:

sebastiencs commented 7 months ago

@gyst That looks good.

Even without copilot, using company-box on a base text with enlarged fonts benefits from adding extra vertical space

Can you add this use case to the documentation of company-box-frame-top-margin, and the link/URL to this pull request too ?

gyst commented 7 months ago

Sure. You mean the documentation on the defcustom, or elsewhere?

gyst commented 7 months ago

There was an issue about that use case, but I wasn't able to find it again.

sebastiencs commented 5 months ago

Thanks @gyst