search

sebastiencs / company-box

A company front-end with icons
562 stars 64 forks source link

Added support for company-tern, company-irony and company-anaconda #66

Closed ema2159 closed 3 years ago

ema2159 commented 5 years ago

This kinda works. company-tern and tern-mode are required. Please review.

a13 commented 5 years ago

you should add smth like (when (require company-tern nil t) …tern-related-code-here) if you don't want to make it a hard dependency, in that case, it should be (require 'company-tern)

ema2159 commented 5 years ago

you should add smth like (when (require company-tern nil t) …tern-related-code-here) if you don't want to make it a hard dependency, in that case, it should be (require 'company-tern)

Thanks, that was a quick answer. Sorry for uploading something so loosely done, I wanted a second opinion so I could get it right and it would be useful for others! I'll proceed to do the changes and then please review them.

ema2159 commented 5 years ago

I already committed, please tell me if it's alright. Also I'll probably also work in supporting other backends just as company-irony or company-anaconda. By the way, this package really really needs to be documented, only the god of free software is able to understand what is happening in this code.

ema2159 commented 5 years ago

Done. Given the company-irony's weird completion API, the company-irony section is a little bit hackish but it works fine. On the other side the company-anaconda section was pretty straight forward