search

sebastiencs / icons-in-terminal

Use any fonts in the terminal without replacing or patching
MIT License
984 stars 46 forks source link

Don't use capitals in Bash, don't use *.sh #45

Open avlapp opened 2 years ago

avlapp commented 2 years ago

A bit nitpicking here:

Bash scripts shouldn't use *.sh as extension

Variables in bash should be lowercase. Uppercase are for environment, internal and shell variables.

So DATA should be lowercase in the install.sh script