Open amoriello opened 6 years ago
Also, before you make it to melpa, I would suggest to generate the icons-in-terminal.el file to try to comply with https://github.com/domtronn/all-the-icons.el
e.g
instead of (icons-in-terminal 'oct_flame))
, do something like (icons-in-terminal-octicon "flame" :face face)
It would help providing terminal support for emacs config using all-the-icons already.
I'm not sure if it's a good idea:
When I will push change on this repo, it will be updated on MELPA too. The file icons-in-terminal.el
will have new codepoints but the user may not have updated icons-in-terminal.ttf
and (s)he will get wrong icons displayed.
I could install the font from elisp but then it will break ls-icons (or others futurs tools) that need to be recompile when a new version of icons-in-terminal
is installed
I see your point, but I don't see major issues here, updating the font (TTF) is a minor operation when already installed.
I don't know about ls-icons, but if you have to build (compile) the tool whenever the font changes, I would say there is something wrong with it.
And how about updating the interface? Making it closer to all-the-icons is important for any configuration that is already using it, to provide a uniform gui/terminal experience (I have https://github.com/hlissner/.emacs.d in mind).
We could obviously adjust the emacs config around your API, but it would be simpler for everybody that you change it make it like to all-the-icons.
Hi,
Just adding my two cents.
Thanks for the wonderful package.
I think you should release this on melpa. You can provide an API similar to all-the-icons. In fact, atleast to my understanding you did most of the work needed in https://github.com/sebastiencs/sidebar.el/blob/master/sidebar-filemapping.el You could refactor that out into an icons-in-terminal package and depend on it.
Personally, I think having to update fonts externally is not a big deal.
Also, I needed a mapping of major-mode with icons and I did some work on it, I can contribute that.
If you end up deciding that you want to add this to Melpa, then you will have to add a proper library header (including permission statement and useful commenary) to icons-in-terminal.el
.
Regardless of whether you add this to Melpa or not, I would like to add it to the Emacsmirror because I try to ensure that all dependencies of all mirrored packages can be satisfied with other mirrored packages and company-box
and omnibox
are already mirrored.
Like Melpa, the Emacsmirror needs packages to provide an elisp library that contains the mentioned metadata. Could you please add that? Thanks!
I had planned using this package in my project, but seems it will never in MELPA or ELPA. It's hard to manage the dependencies then. So, did you have the final decision? I suggest to release on MELPA to let more people know this amazing package.
Is there any updates here?̊̈ @sebastiencs I really would appreciate a properly-packaged MELPA package....
I made https://github.com/seagle0128/icons-in-terminal.el myself.
Hi,
The installation of the emacs binding file isn't compliant with 'standard' package installation from emacs.
Would you please consider registering a recipe to the MELPA repo? No need to automate the installation of the font itself, but focus on
icons-in-terminal.el
, so you don't have to manually change your load-path.Thanks!