search

sebastiencs / sidebar.el

A customizable file explorer with git integration for emacs
293 stars 12 forks source link

Opening sidebar breaks read-only state for helm #6

Open tmstieff opened 6 years ago

tmstieff commented 6 years ago

After opening sidebar, any helm buffer is stuck in read-only. This prevents typing into the search bar, and a restart is required. I've researched how treemacs and neotree resolve this issue, and it looks like they use a major-mode that is read-only by nature. With sidebar, it looks like the read-only state is modified when the new frame is initialized, so maybe the state needs to be reset on frame deactivation?

Emacs 25.3 Helm: Latest

sebastiencs commented 6 years ago

I can't reproduce the issue. I don't have any issue with helm while using sidebar.el

Can you describe a bit more your use case ? Please

tmstieff commented 6 years ago

Let me try it with a barebones Emacs install and see if it persists. Are you only targeting Emacs 24 right now?

sebastiencs commented 6 years ago

Alright. Emacs >=24, I'm using emacs' master branch

tmstieff commented 6 years ago

It seems to be an issue with Evil mode. I have a clean Emacs installation with just sidebar (and requirements) and it was all working. Once Evil is enabled, the mini-buffer get's stuck in read-only mode. I'll have to investigate, but it probably has to do with Evil's modal editing.

ceblan commented 5 years ago

Same here. Looking fordward to get Evil integration. It's a pitty, for me is unusable as is. Great work anyway.