sebastienros / fluid

Fluid is an open-source .NET template engine based on the Liquid template language.
MIT License
1.35k stars 172 forks source link

fix: Directory.Packages.props does not respect PrivateAssets property #645

Closed kaqq closed 2 months ago

kaqq commented 2 months ago

https://github.com/sebastienros/fluid/issues/646

lahma commented 2 months ago

I would suggest moving them to be GlobalPackageReference so they will implicitly be private assets, also no need to reference them in projects either after that.

https://github.com/quartznet/quartznet/blob/72fce9c599e020f4db0b0c77d277f9971d947a6f/Directory.Packages.props#L69-L74

sebastienros commented 2 months ago

Thanks @kaqq , I just published a new release with your fix.

hishamco commented 2 months ago

Ths build is failed!!