search

sebastienros / jint

Javascript Interpreter for .NET
BSD 2-Clause "Simplified" License
4.04k stars 558 forks source link

Support interop against System.Text.Json types on NET8+ #1826

Closed lahma closed 5 months ago

lahma commented 5 months ago

On NET 8+ we can support reading and accessing STJ types without complex and hard to figure out configuration.

ejsmith commented 5 months ago

Can we make sure pushing and popping work on STJ arrays?

lahma commented 5 months ago

Can we make sure pushing and popping work on STJ arrays?

Yes we can. Anyone needing such a feature is welcome to submit the implementation via a PR. Here i'm investigating minimal read model OOTB experience.

ejsmith commented 5 months ago

Thank you. I have been looking into it a bit and trying to understand the code and figure out where the right place to do so would be.

ejsmith commented 5 months ago

Not sure if you will be interested to take my other PR for adding push and pop support to interop arrays, but I pulled this branch down and tried to get it working on JsonArray. I did get it working, but it's pretty hacky. If this PR lands, then I will create a new PR on top to discuss.