search

sebastienros / yessql

A .NET document database working on any RDBMS
MIT License
1.19k stars 196 forks source link

Please add a debugging symbol file to the Nuget package for debugging with Source Link. #494

Open aaronamm opened 1 year ago

aaronamm commented 1 year ago

Hello everyone.

I would be nice if you we could add a debugging symbol file to the Nuget package. This will allow us to debug YesSql with Source Link.

Right now there is no Download symbols link on YesSql Nuget page. image

Therefore, we can't use Source Link to debug to YesSql source code.

I have an issue with YesSql and try to reason why it happened. However, without Source Link, it it not easy to debug into source code.

Here is an issue I found in OrchardCore project and it is related to YesSql. https://github.com/OrchardCMS/OrchardCore/discussions/14174

I hope if you can help adding a debugging symbol file to the package.

Thank you so much.

sebastienros commented 1 year ago

Shouldn't it be sufficient? https://github.com/sebastienros/yessql/blob/main/src/Directory.Build.props#L33-L38

aaronamm commented 1 year ago

@sebastienros thanks for your reply. I have followed this document and can confirm that it does not work. https://lurumad.github.io/using-source-link-in-net-projects-and-how-to-configure-visual-studio-to-use-it

We need to publish snupkg along with YesSql package.

In my Visual Studio, I can't debug into YesSQL source code and it show as Modules without sources as the following screenshot image

However, I can debug into OrchardCore.ContentManagement package because it has been published with snupkg and these is a download symbols link in its Nuget page.

image

Thanks.

aaronamm commented 1 year ago

@sebastienros not sure if you can help to verify if the current release allow us to debug with Source-Link.

Thanks.