Add Async method to SchemaBuilder to prevent possible thread starvation

sebastienros / yessql

A .NET document database working on any RDBMS

MIT License

1.21k stars 197 forks source link

Add Async method to SchemaBuilder to prevent possible thread starvation #508

Closed MikeAlhayek closed 10 months ago

MikeAlhayek commented 10 months ago

Fix #509

Note, there was a bug in the dispose logic of the Session class. The method CommitOrRollbackTransactionAsync has slightly different logic than CommitOrRollbackTransaction. I believe the logic in CommitOrRollbackTransaction is better and used.

sebastienros commented 10 months ago

Unit tests are failing since adding Rollabck in the DbGenerator, only on Sql, maybe the connection is already disposing the transaction. We need to understand what is happening. I am not sure we should just remove it since it's working for other databases. But that's a safety net.

sebastienros commented 10 months ago

Are you getting lazy, or just bored?

MikeAlhayek commented 10 months ago

Are you getting lazy, or just bored?

I wish I was board and have nothing else better to do.

MikeAlhayek commented 10 months ago

@sebastienros I think all the issues are now fixed.

After modifying the CommitOrRollbackTransactionAsync logic, await using var session = ... works as expected and all tests now await and pass.
In the DbBlockIdGenerator, I added the RollbackAsync() call you requested and it now worked. To get that to work, for some reason I had to set throwOnError to true when initializing SchemaBuilder instance.
I also changed all the BeginTransaction calls to BegingTransactonAsync

Now, everything support async which is great! Let me know if you see anything else or if you good with merging this one.