search

sebastinas / yafc

Yafc is yet another ftp client (with some handy features)
Other
45 stars 16 forks source link

Reports stalled even when transferring at >500kbyte/s #33

Open fastcat opened 10 years ago

fastcat commented 10 years ago

I've noticed yafc (debian 1.3.1-2) seems to have broken "stalled" logic. During transfers that are proceeding just fine (often quite fast), the transfer progress bar flickers many times per second between the progress and a transfer rate, and the progress with a stalled message.

fastcat commented 10 years ago

From a quick review of the source, I think I've found the bug:

in plain-socket.c, it sets tv.tv_usec = 500, with a comment of "wait max 0.5 second". Well, 500 usec is NOT 0.5 seconds, it's 0.5 milliseconds! It should be tv.tv_usec = 500000;