sebastiw / edts

Erlang Development Tool Suite
GNU Lesser General Public License v3.0
355 stars 82 forks source link

Alternate styles for `edts-show-doc-under-point` #204

Open jaseemabid opened 9 years ago

jaseemabid commented 9 years ago

The documentation is shown using '(popup-tip text)`, which is hard to keep aside for reference, copy from etc. Does it make sense to configure this function to show it in a help buffer?

I could try a PR if you think it makes sense.

tjarvstrand commented 8 years ago

Sure, why not :)

jaseemabid commented 8 years ago

@tjarvstrand Alright. I'll give it a try soon.

jaseemabid commented 8 years ago

@tjarvstrand Will this do? https://github.com/jaseemabid/edts/commit/4bcd1424ebfcecc8a0496c9bae50ad372d7ca3e5

Comments in the commit message.

jaseemabid commented 8 years ago

I had to switch from print to insert. See 6de97b6 This is what print did: http://lpaste.net/146845 and pp changed it to http://lpaste.net/146846.

I think its working nicely now. See the screenshot.

screen shot 2015-12-10 at 9 23 44 am
jaseemabid commented 8 years ago

@tjarvstrand Ping! :D

tjarvstrand commented 8 years ago

Hey, sorry for the really late reply. I´d prefer if it where either a configurable option or even better a additional command run by adding a modifier key to the original keybinding.

jaseemabid commented 8 years ago

defcustom lets end users customize the variable. Did you mean this or something else?

(defcustom edts-doc-buffer "edts-doc"
  "Name of the buffer to show edts function documentation")

(defcustom edts-doc-style 'tooltip
  "Preferred style to show function documentation"

  :type '(choice (const :tag "Show in an inline tooltip" tooltip)
                 (const :tag "Show in a dedicated buffer" buffer)))
jaseemabid commented 8 years ago

Did you mean trigger this behaviour with C-u C-c C-d h ? That's too long a key sequence.

jaseemabid commented 8 years ago

@tjarvstrand Ping.