henrikcaesar
commented
8 years ago Hi,
I can't seem to get the tests to work, and I am unable to run them on my system as it give me another error (added at the end).
I had a look at the tests and I can not see directly how the change I made caused the test to fail. The last build on master passed 4 months ago, so I assume the tests still should pass.
I might need to update the Pull Request with some debug printouts in order to reproduce and solve the problem. I will investigate further. If you have any comments about the change please let me know before I spend too much time on this.
Thanks and regards, Henrik Caesar
==> edts (ct) Loading erlang-skels... EDTS [info]: Initializing plugin edts_debug EDTS [info]: Initializing plugin edts_dialyzer EDTS [info]: Initializing plugin edts_xref Loading /home/ehencae/src/edts/elisp/edts/edts-project-test.el (source)... Loading /home/ehencae/src/edts/elisp/edts/edts-shell-test.el (source)... Loading /home/ehencae/src/edts/elisp/edts/edts-test.el (source)... Running 1 tests (2015-12-16 10:58:07+0100) passed 1/1 edts-shell-make-comint-buffer-test
Ran 1 tests, 1 results as expected (2015-12-16 10:58:07+0100)
Wrote /home/ehencae/.emacs.d/ac-comphist.dat Loading erlang-skels... EDTS [info]: Initializing plugin edts_debug EDTS [info]: Initializing plugin edts_dialyzer EDTS [info]: Initializing plugin edts_xref Loading /home/ehencae/src/edts/elisp/edts/edts-project-test.el (source)... Loading /home/ehencae/src/edts/elisp/edts/edts-shell-test.el (source)... Loading /home/ehencae/src/edts/elisp/edts/edts-test.el (source)... EDTS [info]: Running test suite: edts-project-suite EDTS [error]: Error running tests backtrace() (progn (edts-log-error "Error running tests") (backtrace) (kill-emacs 2)) (unwind-protect (let ((exit-status 0)) (let ((--dolist-tail-- edts-test-suite-alist) suite) (while --dolist-tail-- (setq suite (car --dolist-tail--)) (let* ((suite-name (car suite)) (stats (edts-test-run-suite-batch suite-name))) (if (zerop (ert-stats-completed-unexpected stats)) nil (setq exit-status 1))) (setq --dolist-tail-- (cdr --dolist-tail--)))) (kill-emacs exit-status)) (progn (edts-log-error "Error running tests") (backtrace) (kill-emacs 2))) edts-test-run-suites-batch-and-exit() command-line-1(("-L" "/home/ehencae/src/edts" "-l" "test/load-tests.el" "-f" "edts-test-run-suites-batch-and-exit")) command-line() normal-top-level() make: *\ [integration-tests] Error 2
tjarvstrand
There is a bug in sit-for that make the call return immediately instead of waiting the wanted numer of seconds. This bug has been around since emacs-23.2 and was fixed Wed, 29 Jul 2015, see:
https://debbugs.gnu.org/cgi/bugreport.cgi?bug=15990 https://debbugs.gnu.org/cgi/bugreport.cgi?bug=20935
This bug make EDTS fail to start with the message:
EDTS: Could not start main server
since the retry loop in edts-api-start-server is executed too fast, before the web server component has started.
Since a many emacs version are affected many users might get into trouble for a long period of time. The fix not even been included in a official emacs release yet. To work around the problem instead of relying on sit-for also check how long time have passed in the while loop condition.