search

sebastiw / edts

Erlang Development Tool Suite
GNU Lesser General Public License v3.0
355 stars 82 forks source link

Migrating to Rebar3 #223

Closed joedevivo closed 4 years ago

joedevivo commented 8 years ago

Well, it's going to be painful, but migrating to rebar3 is going to be the easiest way to add support for Erlang 19. I'm going to need help testing, because I'm sure I'm not using all the features of edts.

This PR will build with Erlang 19, and I've seen it spin up the right nodes, and successfully autocompleted running with this build in my emacs.

The successful build means it's a solution for #217, #218 and #222. It's a little messy, but we can clean it up as we validate things are working. I took some liberty with the plugin structure, since rebar3 offers a cleaner solution for building multiple apps at once.

tjarvstrand commented 7 years ago

Started looking at this today and as you say, it's going to be painful. I'm going to have to get back to you with a full review but I just wanted thank you for putting in so much effort!

getong commented 7 years ago

It looks good. The lager change version to 2.2.3, and webmachine use the master branch. It works in 19.

tsloughter commented 7 years ago

meck should probably be moved to {profiles, [{test, [{deps, [meck]}]}]}.

I wanted to give edts a try again and discovered this issue after installing the one in melpa failed to build :)

mkrusemark commented 7 years ago

Build fails because of dependencies: $ ./rebar3 compile ===> Verifying dependencies... ===> Dependency cycle(s) detected:applications: goldrush lager meck mochiweb webmachine depend on each other

getong commented 4 years ago

This pr can be closed now, the edts is now compiled with rebar3.

sebastiw commented 4 years ago

Done :+1: