sebastiw / edts

Erlang Development Tool Suite
GNU Lesser General Public License v3.0
354 stars 82 forks source link

start dependency lib #265

Closed getong closed 4 years ago

sebastiw commented 4 years ago

what is the issue? what doesn't work? please add a description to the PR as it is hard to review without properly understanding the problem.

getong commented 4 years ago

I use erlang 23.1, just type make and found this error:

===> There are missing function calls in the release.                 
===> Make sure all applications needed at runtime are included in the release.
===> edts_code:format_errors_test_/0 calls undefined function meck:expect/3            
===> edts_code:format_errors_test_/0 calls undefined function meck:new/2               
===> edts_code:format_errors_test_/0 calls undefined function meck:unload/0      
===> edts_code:get_compile_outdir_test_/0 calls undefined function meck:expect/3                          
===> edts_code:get_compile_outdir_test_/0 calls undefined function meck:new/2    
===> edts_code:get_compile_outdir_test_/0 calls undefined function meck:unload/0    
===> edts_code:parse_abstract_function_test_/0 calls undefined function meck:expect/3
===> edts_code:parse_abstract_function_test_/0 calls undefined function meck:new/2
===> edts_code:parse_abstract_function_test_/0 calls undefined function meck:unload/0
===> edts_dialyzer:add_to_plt/2 calls undefined function dialyzer:run/1
===> edts_dialyzer:check_plt/2 calls undefined function dialyzer:run/1
===> edts_dialyzer:create_plt/3 calls undefined function dialyzer:run/1
===> edts_dialyzer:create_plt/3 calls undefined function dialyzer_plt:get_default_plt/0
===> edts_dialyzer:format_warnings/1 calls undefined function dialyzer:format_warning/1
===> edts_dialyzer:format_warnings_test_/0 calls undefined function meck:expect/3
===> edts_dialyzer:format_warnings_test_/0 calls undefined function meck:new/1
===> edts_dialyzer:format_warnings_test_/0 calls undefined function meck:unload/0
===> edts_dialyzer:get_included_files/1 calls undefined function dialyzer:plt_info/1
===> edts_dialyzer:get_plt_warnings/1 calls undefined function dialyzer:run/1
===> edts_dialyzer:meck_history/3 calls undefined function meck:history/1
===> edts_dialyzer:remove_from_plt/2 calls undefined function dialyzer:run/1
===> edts_dialyzer:update_plt_test_/0 calls undefined function meck:exception/2
===> edts_dialyzer:update_plt_test_/0 calls undefined function meck:expect/3
===> edts_dialyzer:update_plt_test_/0 calls undefined function meck:expect/4
===> edts_dialyzer:update_plt_test_/0 calls undefined function meck:history/1
===> edts_dialyzer:update_plt_test_/0 calls undefined function meck:new/1
===> edts_dialyzer:update_plt_test_/0 calls undefined function meck:new/2
===> edts_dialyzer:update_plt_test_/0 calls undefined function meck:passthrough/1
===> edts_dialyzer:update_plt_test_/0 calls undefined function meck:unload/0
===> edts_dialyzer:update_plt_test_/0 calls undefined function meck:unload/1
===> edts_server:init_node_test/0 calls undefined function meck:expect/3
===> edts_server:init_node_test/0 calls undefined function meck:new/1
===> edts_server:init_node_test/0 calls undefined function meck:unload/0
===> edts_util:expand_code_path_test/0 calls undefined function meck:expect/3
===> edts_util:expand_code_path_test/0 calls undefined function meck:new/2
===> edts_util:expand_code_path_test/0 calls undefined function meck:unload/0
===> edts_xref_server:compile_and_add_test_module/3 calls undefined function xref:info/2
===> edts_xref_server:do_query/2 calls undefined function xref:q/2
===> edts_xref_server:do_start/0 calls undefined function xref:start/1
===> edts_xref_server:do_start_with/1 calls undefined function xref:set_default/2
===> edts_xref_server:eunit_test_init/0 calls undefined function meck:expect/3
===> edts_xref_server:eunit_test_init/0 calls undefined function meck:new/2
===> edts_xref_server:eunit_test_init/0 calls undefined function meck:unload/0
===> edts_xref_server:start_from_state_test/0 calls undefined function xref:info/2
===> edts_xref_server:start_from_state_test/0 calls undefined function xref:remove_module/2
===> edts_xref_server:start_from_state_test/0 calls undefined function xref:stop/1
===> edts_xref_server:stop/0 calls undefined function xref:stop/1
===> edts_xref_server:teardown_eunit/0 calls undefined function meck:unload/0
===> edts_xref_server:try_add_module/2 calls undefined function xref:add_module/2
===> edts_xref_server:update/0 calls undefined function xref:update/1
===> edts_xref_server:update_modules/1 calls undefined function xref:info/2
===> edts_xref_server:update_modules/1 calls undefined function xref:update/1
sebastiw commented 4 years ago

Thank you, but it's the wrong way to fix it. meck shouldn't be part of the release. I removed the warnings in #267, going to test it locally before merging as usual. As far as I can see there are only warnings and no errors, and it still builds a release. Closing this PR.