search

sebble / SebbleDMS

Secure data management (PHP, AJAX)
Other
2 stars 2 forks source link

Internet Explorer compatability #4

Closed keithnewman closed 13 years ago

keithnewman commented 13 years ago

Below is the original line from the code. As you would expect, removing it means Chrome and Firefox no longer change the title of the page when a new section is loaded. For some reason, removing it means IE8 (and even IE7) will start to load the content as intended, and Chrome and Firefox still work.

$('title').jqotesub($('#tpl-title'), {});

IE8 does not object to the following line existing:

$('#ui-title').jqotesub($('#tpl-title'), {});

But this may not be much use as doesn't support classes according to W3C. The whole IE issue could actually stem from <title> not supporting standard event attributes according to W3C, but this might conflict with witnessing other sites loaded in IE being able to change the title of the page using javascript.</p> </div> </div> <div class="comment"> <div class="user"> <a rel="noreferrer nofollow" target="_blank" href="https://github.com/sebble"><img src="https://avatars.githubusercontent.com/u/545273?v=4" />sebble</a> commented <strong> 13 years ago</strong> </div> <div class="markdown-body"> <p>Hey, see here: <a href="http://bugs.jquery.com/ticket/2755">http://bugs.jquery.com/ticket/2755</a>, and then admin.js line ~397.</p> </div> </div> <div class="comment"> <div class="user"> <a rel="noreferrer nofollow" target="_blank" href="https://github.com/keithnewman"><img src="https://avatars.githubusercontent.com/u/932250?v=4" />keithnewman</a> commented <strong> 13 years ago</strong> </div> <div class="markdown-body"> <p>Titles in IE now change correctly</p> </div> </div> <div class="comment"> <div class="user"> <a rel="noreferrer nofollow" target="_blank" href="https://github.com/keithnewman"><img src="https://avatars.githubusercontent.com/u/932250?v=4" />keithnewman</a> commented <strong> 13 years ago</strong> </div> <div class="markdown-body"> <p>Sorry. I didn't necessarily mean to close that.</p> </div> </div> <div class="comment"> <div class="user"> <a rel="noreferrer nofollow" target="_blank" href="https://github.com/sebble"><img src="https://avatars.githubusercontent.com/u/545273?v=4" />sebble</a> commented <strong> 13 years ago</strong> </div> <div class="markdown-body"> <p>Interesting, I was wondering if you could close. Can't be assigned but can close things..? Do we have any other IE issues? Should start a new issues if we do. Feel free to repoen if this fix isn't sufficient.</p> </div> </div> <div class="page-bar-simple"> </div> <div class="footer"> <ul class="body"> <li>© <script> document.write(new Date().getFullYear()) </script> Githubissues.</li> <li>Githubissues is a development platform for aggregating issues.</li> </ul> </div> <script src="https://cdn.jsdelivr.net/npm/jquery@3.5.1/dist/jquery.min.js"></script> <script src="/githubissues/assets/js.js"></script> <script src="/githubissues/assets/markdown.js"></script> <script src="https://cdn.jsdelivr.net/gh/highlightjs/cdn-release@11.4.0/build/highlight.min.js"></script> <script src="https://cdn.jsdelivr.net/gh/highlightjs/cdn-release@11.4.0/build/languages/go.min.js"></script> <script> hljs.highlightAll(); </script> </body> </html>