sebbo2002 / node-pyatv

A lightweight node.js wrapper around pyatv…
MIT License
26 stars 2 forks source link

Simple `outputDevices` value comparison #300

Closed sebbo2002 closed 6 months ago

maxileith commented 6 months ago

Sorry to bother you again, I haven´t look at it close enough ...

This does not really compare it correct, see screenshot. I would just leave the check out or do it with a true deepEqual. I think a solution that solves only half of the problem is worse then leaving it out ...

image

A deepEqual might truely be overkill, so I think the best option now is to revert this PR and leave everything like before.

Sorry about beeing so picky ^^

sebbo2002 commented 6 months ago

@maxileith Ou. I forgot to add .identifier. Sure, you can't sort objects, but you can sort the array by their identifier. Thanks for "beeing so picky", I really appreciate it.

sebbo2002 commented 6 months ago

:tada: This PR is included in version 7.3.0-develop.3 :tada:

The release is available on:

Your semantic-release bot :package::rocket:

sebbo2002 commented 5 months ago

:tada: This PR is included in version 7.3.0 :tada:

The release is available on:

Your semantic-release bot :package::rocket: