Closed maxileith closed 6 months ago
:tada: This PR is included in version 7.3.0-develop.3 :tada:
The release is available on:
v7.3.0-develop.3
Your semantic-release bot :package::rocket:
:tada: This PR is included in version 7.3.0 :tada:
The release is available on:
Your semantic-release bot :package::rocket:
Currently, if
atvscript
is reporting{"result": "success", "datetime": "xxx", "volume": 0.0}
, all events but volume are triggered, sincevolume
is not catched as a special case. The reason is that the conditionnewState.volume
is false for0.0
. Therefore, the condition should benewState.volume !== null
.https://github.com/sebbo2002/node-pyatv/blob/478f2ddb97af0dc2e4ffa417aecacbbf76d22ab3/src/lib/device-events.ts#L59-L63
About this Pull Request
update:mediaType
is triggered although it shouldn'tPull Request Checklist
npm run lint
to double checknpm run test
to run the unit tests andnpm run coverage
to generate a coverage report