sebbo2002 / pyatv-mqtt-bridge

Bridge which allows you to control your Apple TV via MQTT
MIT License
36 stars 8 forks source link

Get the Artwork #183

Open HeXaN-Prime opened 2 years ago

HeXaN-Prime commented 2 years ago

Hi,

in pyatv there is the possibility to get the Artwork. Is it possible to integrate this in the mqtt bridge?

Thanks a lot.

sebbo2002 commented 2 years ago

Of course, it would be theoretically possible, but there are some open questions, which is why this feature is currently not implemented:

These points have currently caused me not to implement this feature. But of course I would be happy about a corresponding pull request.

github-actions[bot] commented 1 year ago

This issue has been automatically marked as stale because it has not had recent activity :sleeping: It will be closed in 14 days if no further activity occurs. To unstale this issue, add a comment with detailed explanation. Thank you for your contributions :heart:

chrigu1981 commented 1 year ago

implementing the URL would be enough for me

github-actions[bot] commented 1 year ago

This issue has been automatically marked as stale because it has not had recent activity :sleeping: It will be closed in 14 days if no further activity occurs. To unstale this issue, add a comment with detailed explanation. Thank you for your contributions :heart:

asherry99 commented 10 months ago

+1 for this for reconsideration in the future. I think bringing in Artwork would be be of huge value to the project. But I understand your trade off / considerations above. My use case is I use pyatv-mqtt to display and control whats playing within my HA system so bringing in Artwork is of high desire.

My two cents, base64 of the image pushed over mqtt would be prefered over the URL as that feels simpler and more inline w/ a bridge than running a server. Hosting a URL means opening ports and setting up routing. But I'd take any solution.

SidM01 commented 8 months ago

+1 I would also like the function to transfer the image (preferably via a URL) and would be very happy

asherry99 commented 1 month ago

@sebbo2002 Would be be possible to keep this Issue open (instead of the stale auto closure)? Maybe re-label it Feature Request: Get the Artwork or use a Feature Request GH labels to allow it stay open?

My hope is by it being an open issue and not closed one more people will see it and eventually it's enough of a desire/traction that someone runs with this? I think it would be a huge value add the the project, but understand there's still open questions and a decent amount of time that would go into implementing it. I just worry by it being closed it feels like a totally dead issue. 🤷🏻‍♂️