sebdah / dynamic-dynamodb

Dynamic DynamoDB provides auto scaling for AWS DynamoDB
http://dynamic-dynamodb.readthedocs.org/
Apache License 2.0
617 stars 124 forks source link

Prevents scaling down write capacity as long as there are throttled w… #319

Closed grom-it closed 6 years ago

grom-it commented 7 years ago

…rite requests.

Please integrate this commit into the main project. It solves the following issue:

The dynamic DynamoDB scaler considers the used write capacity and the number of throttled writes when scaling up. This works fine. But when scaling down it only considers the used write capacity - but ignores the throttled writes. This made the scaler scaling capacity up and down continuously when the used write capacity collapsed due to throttled writes.

So I added a little check that prevents it from scaling down as long as there are still throttled writes.

Cheers Robert

nigels-com commented 7 years ago

Yes, that's a good criteria, agreed.