search

sebdah / goldie

Golden file testing for Go
MIT License
228 stars 19 forks source link

Change FixtureDir to `testdata` #10

Closed xorcare closed 5 years ago

xorcare commented 5 years ago

By default, this package uses the directory FixtureDir = "fixtures" , but in Go common practice of using the name testdata I would like to see that you have in the package by default used the dir name testdata

Examples in standard library https://github.com/golang/go/tree/master/src/cmd/gofmt/testdata https://github.com/golang/go/tree/master/src/encoding/json/testdata

P. S. For backward compatibility, you need to share version tags for v1.0.0 and v2.0.0 to current users of the library have not received problems.

sebdah commented 5 years ago

@gtrevg Thanks for implementing this. It has just now been merged to master with the v2.0.0 release.