sebescudie / GammaLauncher

A simple launcher for VVVV Gamma
GNU General Public License v3.0
48 stars 7 forks source link

Clean old folders in install directory #34

Closed tebjan closed 9 months ago

tebjan commented 2 years ago

Uninstalling vvvv leaves a folder there, if one is sure that nothing was changed manually in a vvvv install folder, one could press a button to move those directories into the bin.

image
sebescudie commented 2 years ago

Hey, yes noticed that as well, I could actually delete this folder when the uninstaller successfully exits, but shouldn't/couldn't it be taken care of by the uninstaller?

tebjan commented 2 years ago

This might be the first thought, of course. But the installer is only allowed to remove files that it put there itself. We don't know what a user did or whether some files are changed, so we cannot just delete this folder as it could potentially destroy user work.

so the cleanup has to be an active user decision, which is better placed in the launcher. also, the installer would only be allowed to manage its own specific version, but in this case, one just wants to clean all.

sebescudie commented 9 months ago

This feature will be part of the next release!

There is a quirk though. It looks like the Launcher has to run in elevated mode to delete files in Program Files, which makes sense.

But apparently, a non-elevated program cannot send messages (like a drag and drop action) to an elevated one. Windows Explorer is usually not elevated, which means that the feature that allows to open a document by dropping it on the Launcher will not work in elevated mode.