search

sebfz1 / wicket-jquery-ui

jQuery UI & Kendo UI integration in Wicket
http://www.7thweb.net/wicket-jquery-ui/
Other
93 stars 58 forks source link

It is impossible to override feedback in the Wizard #201

Closed solomax closed 9 years ago

solomax commented 9 years ago

Hello Sebastien,

I would like to replace standard feedback of Wizard with my own one (I would like to use KendoUI feedback with button) I guess currently it is impossible :( Maybe some overridable method can be added to AbstractWizard to be able to to this? Something like:

protected FeedbackPanel newFeedbackPanel(final String id) {
    return /* any custom feedback here*/;
}

Thanks in advance!

sebfz1 commented 9 years ago

Hi Maxim,

Done. I am deploying snapshots versions (6.20.2-SNAPSHOT & 7.0.2-SNAPSHOT), but since last releases the code may not be fully aligned on 6.x & 7.x.

So far the 7.x changelog looks like:

15a58ef (HEAD, origin/master, origin/HEAD, master) jQueryUI: added AbstractWizard#newFeedbackPanel; fixes #201 AbstractWizard#getFeedbackPanel() now returns WebMarkupContainer 12773f1 Kendo UI: Reworking DataTable button (toolbar & command)

0c561b9 Kendo UI: AutoCompleteTextField, restored converter & added Class ctor's arg e6588da Kendo UI: DataTable, reload now also resets by default 67d5a32 Kendo UI: added CheckBox Samples: Added KendoCheckPage & KendoCheckBoxPage 709fc41 Core: Added JQueryTemplate e17b921 Kendo UI: Added AbstractAutoCompleteTextField#getChoices Kendo UI: AutoCompleteTextField, removed useless converter (type nevergiven to ctor) 6339aba Kendo UI: removed lazy.MultiSelect#convertValue, added #convertInput (there is no converter) 5a076e7 Kendo UI: removed non-functioning DropDownList template ability, use lazy.DropDownList instead - API BREAK c007d2a Kendo UI: Added lazy.DropDownList, for a better support of template usage be022ca Core: Added ChoiceModelBehavior#ctor with IJQueryTemplate Core: Added ITextRenderer#getFields Kendo UI: enhanced usage of datasource (AutoCompleteTextField, ComboBox, MultiSelect) bf6c861 Kendo UI: Added KendoFeedbackPanel#refresh + enhancement b0cc9d9 Kendo UI: Added ResponsiveAdapter 39bb13c Kendo UI: Updated local.DateTimePicker; #199 91e32ab Kendo UI: DateTimePicker, always gets a new converter; fixes #199 cc23f48 Kendo UI: Added WindowButton#isIndicating(), so 'submit' window-buttons are now indicating buttons (and disabled on click) 6b164a4 Core: Added ListUtils#exclude

Kendo UI: ComboBox#newDataSource, use ListUtils#exclude; fixes #198

solomax commented 9 years ago

Thanks a lot! will try to test ASAP

solomax commented 9 years ago

just have tried it unfortunately there seems to be an issue: "[feedback]" placeholder is being displayed on the wizard :(

trying to use it as follows

@Override
protected WebMarkupContainer newFeedbackPanel(String id) {
    KendoFeedbackPanel feedback = new KendoFeedbackPanel("feedback", new Options("button", true));
    feedback.setEscapeModelStrings(false);
    return feedback;
}
solomax commented 9 years ago

Additionally: is it possible not to close Wizard in onClick" method if Finish button is pressed?

sebfz1 commented 9 years ago

Oops, correcting (and testing :p)...

sebfz1 commented 9 years ago

"[feedback]" placeholder is being displayed on the wizard

corrected

sebfz1 commented 9 years ago

is it possible not to close Wizard in onClick" method if Finish button is pressed?

Yes, but that's not the case yet. Are you sure you want this? Because it may lead to a (silent) api break...

solomax commented 9 years ago

Actually I'm using wizard to provide installer wizard functionality And I need to display progress, then close the wizard

To avoid API break optional property OFF by default maybe introduced (or overridable getter method returning boolean)

sebfz1 commented 9 years ago

Understood & agreed...

solomax commented 9 years ago

Thanks!

solomax commented 9 years ago

Perfect! Thanks!

sebfz1 commented 9 years ago

I will deploy 7.0.2-SNAPSHOT later today... I will try to align with wicket6.x asap (I'm almost sure cannot cherrypick, at least one of the commits)

solomax commented 9 years ago

sure, I also can test only tomorrow, sitting at the airport now :)

sebfz1 commented 9 years ago

Well... You are at the airport since a while now ! :/

solomax commented 9 years ago

I got connection in Moscow for 5 hours found free wifi and power outlet, can do some wicket-jquery-ui testing :))))

sebfz1 commented 9 years ago

Lucky me, lol ! ;)

sebfz1 commented 9 years ago

Hi Maxim,

I've redeployed 6.20.2-SNAPSHOT & 7.0.2-SNAPSHOT yesterday evening. I will redeploy tonight with #204 fix...

Enjoy! :) Sebastien.

solomax commented 9 years ago

Great, thanks a lot! will test both :)

solomax commented 9 years ago

Just have tested 6.20.2-SNAPSHOT, everything seems to work Do you have any plans for release date? :))

sebfz1 commented 9 years ago

Hi Maxim,

Glad to read this!

Well bugfix-releases are outside wicket's release planning.... So I can do it this WE.. ;)

Best regards, Sebastien.

solomax commented 9 years ago

great! Will wait for it! Thanks a lot!

solomax commented 9 years ago

Hello Sebastien, Can you please release 6.20.2 and 7.02, it is extremely hard to work with maven snapshots with ivy :(

sebfz1 commented 9 years ago

Let me check my status and if I'm clean (what I think), I'll do it in a few minutes... :)

On Thu, Oct 8, 2015 at 7:27 PM, Maxim Solodovnik notifications@github.com wrote:

Hello Sebastien, Can you please release 6.20.2 and 7.02, it is extremely hard to work with maven snapshots with ivy :(

— Reply to this email directly or view it on GitHub https://github.com/sebfz1/wicket-jquery-ui/issues/201#issuecomment-146630923 .

solomax commented 9 years ago

I can see 7.0.2, Thanks!

sebfz1 commented 9 years ago

6.20.2 is also released, it should appear in maven central soon... Enjoy! :)