No way to control DialogBehavior behaviours in AbstractDialog.

[Jezza]

The newWidgetBehavior method is final, as such, we can't replace or customise the return value for newOnDefaultCloseAjaxBehavior. That locks out a lot of possible customisation options. I understand why you made it final, so you could handle various parts of the form, etc in the AbstractFormDialog, but I don't think it's much of a concern. If someone overrides newWidgetBehaviour they either know what they're doing, or it's just going to stop working. I'd prefer something like wicket's style. It has public internal API methods that you shouldn't use unless you know what you're doing. I'd make it as a that, and make it non-final.

Also, make CloseEvent public as well, otherwise we can't access it.

I'll submit a PR if you have no issue with this.

[sebfz1]

Hi, I'm on vacation for a few days, I will look at this next week ! :)

[sebfz1]

I've removed all final modifier on all newWidgetBehavior method, and created needed factory methods for XxxListenerWrapper (wicket8.x branch).

About CloseEvent, you can access it when you override DialogBehavior. If you access it outside this scope, I'd like to understand why before changing. My point is that all XxxEvent extends JQueryEvent are protected in the API (no exception). If I change for one, I'd rather like to change for all for consistency.

[Jezza]

Sweet, the changes look good.

About the CloseEvent, I think the main reason I wanted it public was because we were posting another CloseEvent to the dialog, so panels and whatnot could cleanup after a dialog close, if they supported it.

And I think it was just a matter of unifying the events, but after some thought, yeah, the JQueryEvents are mostly internal use, so I'm fine with you leaving it the way it is.