Fixes issue #315: 'this' is saved before use

sebfz1 / wicket-jquery-ui

jQuery UI & Kendo UI integration in Wicket

http://www.7thweb.net/wicket-jquery-ui/

Other

92 stars 58 forks source link

Closed solomax closed 4 years ago

solomax commented 4 years ago

Monkey-patching due to original plugin seems to be abandoned

sebfz1 commented 4 years ago

Thanks Maxim and Martin! :) I'll do the minimized version, merge and release asap...

solomax commented 4 years ago

Thanks @sebfz1 ! :) (was sure command line uglify should work as expected :(( )

sebfz1 commented 4 years ago

uglifyjs bootstrap-wysiwyg.js -cm -o bootstrap-wysiwyg.min.js I believe the "mangle" option was missing

solomax commented 4 years ago

Always thought it is something from "Harry Potter" ;) Thanks again :)

sebfz1 commented 4 years ago

Always thought it is something from "Harry Potter" ;)

Haha, was my impression too! :) Merged as 3a9b264ad66ab5b1dfaea814e41e784dfa43ca8e

solomax commented 4 years ago

Hello @sebfz1 When do you plan to deploy maven artifacts? :)

solomax commented 4 years ago

BTW, maybe it worth to cherry-pick this fix to 8.x?

sebfz1 commented 4 years ago

Already cherry picked :) I will release M5.1 today...