sebfz1 / wicket-jquery-ui

jQuery UI & Kendo UI integration in Wicket
http://www.7thweb.net/wicket-jquery-ui/
Other
92 stars 58 forks source link

release 9.1.0? #321

Closed reiern70 closed 3 years ago

reiern70 commented 3 years ago

Hi,

We need a 9.1.0 release for our project.

@sebfz1

Do you think it would be good to move this project to wicketstuff?

reiern70 commented 3 years ago

https://github.com/sebfz1/wicket-jquery-ui/pull/322

sebfz1 commented 3 years ago

Hi Ernesto!

I planned to do it next weekend because it requires me to test it before (following the discussions about CSP mainly)... If it's urgent for you I can try to manage tomorrow... Please let me know. I am not closed about moving the project to wicket-stuff if it make sense. Not sure it is the case, it will probably require a non negligeable amount of work (I'm thinking about the demo site for instance)... In another hand, I do not have any issue giving you and Maxim the key to release the project from here.

WDYT?

reiern70 commented 3 years ago

Hi Ernesto! I planned to do it next weekend because it requires me to test it before (following the discussions about CSP mainly)... If it's urgent for you I can try to manage tomorrow... Please let me know. I am not closed about moving the project to wicket-stuff if it make sense. Not sure it is the case, it will probably require a non negligeable amount of work (I'm thinking about the demo site for instance)... In another hand, I do not have any issue giving you and Maxim the key to release the project from here. WDYT?

Hi,

Many thanks for your answer. No need to do it now. We can wait for weekend. I can also try to help during this week as our project depends on your library. Project compiles and installs (mvn clean install) against 9.1.x. Please let me know how can I help.

sebfz1 commented 3 years ago

The only help I would need would be to upgrade wicket version to 9.0.1 and test some samples (mainly kendo) to see if there is no issue with CSP. Everything is currently working fine with 9.0.0 so I guess that's the only thing to have a look at... Btw, there is no need to upgrade the project version in the poms from snapshot to final, it is automatically done by mvn release

reiern70 commented 3 years ago

@sebfz1

As far as I can see Kendo UI integration is working.

image

image

image

image

image

image

image

image

image

Also Jequery UI

image

These we are using extensibly. Thus we will provided feedback if something is broken.

reiern70 commented 3 years ago

Only some warnings in console

image

sebfz1 commented 3 years ago

Great! Thank you so much Ernesto!!

reiern70 commented 3 years ago

Great! Thank you so much Ernesto!!

Thanks to you for maintaining the software we use...

reiern70 commented 3 years ago

Let me know if any more actions are needed from my side.

sebfz1 commented 3 years ago

Hi Ernesto! 9.1.0 is on its way to maven central. Thanks for your help testing the upgrade to wicket 9.1.0!

reiern70 commented 3 years ago

Thanks to you!