search

sebfz1 / wicket-jquery-ui

jQuery UI & Kendo UI integration in Wicket
http://www.7thweb.net/wicket-jquery-ui/
Other
92 stars 58 forks source link

In 8.11.0 DataTable can't be instantiated if it is not selectable and doesn't contain CheckBox column #329

Closed pekour closed 3 years ago

pekour commented 3 years ago

Hi. It looks like com.googlecode.wicket.kendo.ui.datatable.DataTableBehavior#newOnChangeAjaxBehavior makes DataTable constantly failing to initialize when it is not selectable and has no CheckboxColumn:

     at org.apache.wicket.util.lang.Args.notNull(Args.java:41)
     at org.apache.wicket.Behaviors.add(Behaviors.java:46)
     at org.apache.wicket.Component.add(Component.java:4481)
     at com.googlecode.wicket.kendo.ui.datatable.DataTableBehavior.bind(DataTableBehavior.java:122)
     at org.apache.wicket.Behaviors.add(Behaviors.java:56)
     at org.apache.wicket.Component.add(Component.java:4481)
     at com.googlecode.wicket.kendo.ui.datatable.DataTable.onInitialize(DataTable.java:341)
sebfz1 commented 3 years ago

Hi Alexander, thanks for reporting!

CheckboxColumn is indeed a new feature. Maybe I missed something somewhere... I'll look at it asap and publish a patch release.

pekour commented 3 years ago

Thank you!

sebfz1 commented 3 years ago

Released 8.11.1

mdbergmann commented 3 years ago

Hi @sebfz1

Is this fix also in Wicket 9 branch? I'm seeing similar issues in tests with wicket-kendo-ui:9.2.1

  java.lang.IllegalArgumentException: Argument 'behavior' may not be null.
  at org.apache.wicket.util.lang.Args.notNull(Args.java:41)
  at org.apache.wicket.Behaviors.add(Behaviors.java:46)
  at org.apache.wicket.Component.add(Component.java:4496)
  at com.googlecode.wicket.kendo.ui.datatable.DataTableBehavior.bind(DataTableBehavior.java:122)
  at org.apache.wicket.Behaviors.add(Behaviors.java:56)
  at org.apache.wicket.Component.add(Component.java:4496)
  at com.googlecode.wicket.kendo.ui.datatable.DataTable.onInitialize(DataTable.java:341)
sebfz1 commented 3 years ago

Yes the fix is in the wicket 9 branch. I will release 9.3.0 asap

sebfz1 commented 3 years ago

Released 9.3.0

EveryonePrint-dev commented 3 years ago

Cool, it works. Thanks