search

sebfz1 / wicket-jquery-ui

jQuery UI & Kendo UI integration in Wicket
http://www.7thweb.net/wicket-jquery-ui/
Other
93 stars 58 forks source link

fullcalendar is updated to latest 3.x version: 3.10.2 #335

Closed solomax closed 3 years ago

solomax commented 3 years ago

Hello @sebfz1,

could you lease create SNAPSHOT with this version? :)

BTW latest version of fullcalendar is 5.7.2, new version has no dependencies to jquery, jquery-ui and moment.js shall I try to create PR with update to this version? or maybe you have time for this? :)

solomax commented 3 years ago

@sebfz1 ping :)

sebfz1 commented 3 years ago

Thanks! I'll do it tomorrow or Saturday! :)

On Thu, Jun 17, 2021, 20:45 Martin Grigorov @.***> wrote:

@.**** approved this pull request.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/sebfz1/wicket-jquery-ui/pull/335#pullrequestreview-686203133, or unsubscribe https://github.com/notifications/unsubscribe-auth/AANDHGDL7WRE7KEDGN3DJLLTTHN4PANCNFSM46YKTR3A .

sebfz1 commented 3 years ago

Hi Maxim, deployed 9.3.2-SNAPSHOT. I tried removing the dependency to moment.js but it didn't worked. I'll try to investigate... I you think it's good to be released, I will release 9.3.2...

solomax commented 3 years ago

Thanks for the SNAPSHOT @sebfz1 !

weird enough this file https://github.com/sebfz1/wicket-jquery-ui/blob/wicket9.x/wicket-jquery-ui-calendar/src/main/resources/com/googlecode/wicket/jquery/ui/calendar/resource/fullcalendar.js still has old version :(

moment.js is not required since v4 https://fullcalendar.io/docs/v4/upgrading-from-v3

Both v4 and v5 introduces breaking changes https://fullcalendar.io/docs/upgrading-from-v4

So I guess it worth to migrate to v5 directly ...

sebfz1 commented 3 years ago

I deployed the snapshot from another branch from your commit. I will merge as soon as you confirm it's working as expected....

solomax commented 3 years ago

everything works as expected, thanks! :)