search

sebfz1 / wicket-jquery-ui

jQuery UI & Kendo UI integration in Wicket
http://www.7thweb.net/wicket-jquery-ui/
Other
92 stars 58 forks source link

AutoCompleteChoiceModelBehavior sets wrong index #342

Closed stekuth closed 2 years ago

stekuth commented 2 years ago

You used to start with index 1 in AutoCompleteChoiceModelBehavior before the change to JSONObject So imho this line should be changed, to add 1: object.put("id", Integer.toString(index + 1)); / 'id' is a reserved word / Now the code in AutoCompleteBehavior still subtracts 1 from the returned index, so the wrong entry is selected

greetings! Stefan

sebfz1 commented 2 years ago

Just had a look at the issue, well done! I will remove the "substracts 1" from the SelectEvent then, and release asap...

sebfz1 commented 2 years ago

Deployed 9.8.0-SNAPSHOT. If you can test it this week that would be great, I will release this week-end. If you need 8.x instead please let me know...

stekuth commented 2 years ago

Hello, thanks for fixing this - I tested it and it works! greetings

stekuth commented 2 years ago

could you also please push a 9.8.0 release including this fix to maven-repo?

sebfz1 commented 2 years ago

Hi Stefan,

I was about to release yesterday, but I came across an issue with the last release of kendo ui, and I don't know yet if it's their mistake or my web application design... I need to test further. If you need a release asap I can deploy tonight without the latest version of kendo ui, and release 9.8.1 later hopefully...

sebfz1 commented 2 years ago

Actually my spare time will be almost null for the next 10 days so I released 9.8.0. Should be available in Maven Central soon...