search

sebfz1 / wicket-jquery-ui

jQuery UI & Kendo UI integration in Wicket
http://www.7thweb.net/wicket-jquery-ui/
Other
92 stars 58 forks source link

Broken style in dialogue box between 8.11 and 9.8 #345

Closed tverdokhlebd closed 2 years ago

tverdokhlebd commented 2 years ago

The difference in the style in a dialogue box:

8.11.1: 8 11 org.apache.wicket 8.13 com.googlecode 8.11.1 (wicket-kendo-ui, wicket-kendo-ui-theme-material, wicket-kendo-ui-culture)

9.8: 9 8 org.apache.wicket 9.8.0 com.googlecode 9.8.0 (wicket-kendo-ui, wicket-kendo-ui-theme-material, wicket-kendo-ui-culture)

Kendo UI JS 2021.1.224

Is it an issue for this repo?

sebfz1 commented 2 years ago

Thanks for reporting this! I'll investigate...

tverdokhlebd commented 2 years ago

@sebfz1 Any news?

sebfz1 commented 2 years ago

So sorry I didn't replied earlier. I tested some time ago already and I really couldn't reproduce the issue. I was thinking it should be a conflict between the api version and the theme version, but I didn't get a chance to test. Please double check on your end, and please create a quickstart that repro the issue so I have something to work with. Worth to note that the latest version of kendo ui jas similar issues (on combobox/dropdown and I didn't release it for this reason...

tverdokhlebd commented 2 years ago

So, I applied Wicket 9.8 (wicket-kendo-ui, wicket-kendo-ui-theme-material, wicket-kendo-ui-culture) and the latest version of Kendo UI JS 2022.1.412.

The result is: delete_container_2 Something is different compared to Wicket 8.11.1, the distance between icon and button, but, the title bar looks normal.

However, I got another problem with combobox/dropdown components: image Is this the problem, that you have noted?

sebfz1 commented 2 years ago

Hi,

Yes, looks like the issue I noted. As a side note, you cannot mix js and theme versions. They have to be the same. You don't need to provide the kendo js (core), it's already bundled. Except if it's to provide the kendo-ui-all.js. In that case be sure it's the same version than the theme. You have the versions table in the readme.

On Mon, May 2, 2022, 14:29 Dmitry Tverdokhleb @.***> wrote:

So, I applied Wicket 9.8 (wicket-kendo-ui, wicket-kendo-ui-theme-material, wicket-kendo-ui-culture) and the latest version of Kendo UI JS 2022.1.412.

The result is: [image: delete_container_2] https://user-images.githubusercontent.com/10245067/166232687-1371af91-a9c9-4606-a8cd-ef2812bef55f.PNG Something is different compared to Wicket 8.11.1, the distance between icon and button, but, the title bar looks normal.

However, I got another problem with combobox/dropdown components: [image: image] https://user-images.githubusercontent.com/10245067/166233282-9944df96-f9b8-4136-9d78-96d8fcdc8330.png Is this the problem, that you have noted?

— Reply to this email directly, view it on GitHub https://github.com/sebfz1/wicket-jquery-ui/issues/345#issuecomment-1114791575, or unsubscribe https://github.com/notifications/unsubscribe-auth/AANDHGF5Q3LGELNPEYU2TD3VH7DCDANCNFSM5SCPTZRA . You are receiving this because you were mentioned.Message ID: @.***>

tverdokhlebd commented 2 years ago

@sebfz1 , could you tell me, what is the version of Kendo UI for Wicket 9.8? There is a version for only 9.7 in the readme.

sebfz1 commented 2 years ago

Strange that it's not up to date... The version should be 2021.3.1207

tverdokhlebd commented 2 years ago

Checked on Wicket 9.8 with the correct version (2021.3.1207) of Kendo UI JS. The problem described above does not reproduce.

tverdokhlebd commented 2 years ago

@sebfz1 After updating to 2021.3.1207, found strange behavior for tabs: 1 Non selected tab is filled with white color, and the whole background color is blue (Should be white or transparent).

tverdokhlebd commented 2 years ago

@sebfz1 could you check this in your free time?

sebfz1 commented 2 years ago

Hi have upgraded to kendo-ui-2022.2.510, please give a try to 9.9.1-SNAPSHOT. There is still some other issues with dropdown and co I need to investigate. Any help is very welcome!