sebhildebrandt / systeminformation

System Information Library for Node.JS
MIT License
2.76k stars 315 forks source link

processes(): "mem" value missing on Windows #531

Closed GitSquared closed 3 years ago

GitSquared commented 3 years ago

Describe the bug From the docs: image

I can find this value on Linux but it's missing on windows.

To Reproduce systeminformation.processes().then(d => console.log(d)) on Windows

Current Output

...
list: [
    {
        ...
        cpu: 0.004,
        pmem: 0.003, // Should this be mem?
        memRss: 6008,
        memVsz: 1128,
        ...
]
...

Expected behavior A mem value accross all OSs that reports memory usage of the process in %.

Environment (please complete the following information):

Additional context (in eDEX-UI)

GitSquared commented 3 years ago

I think this might be a simple fix of renaming this to mem to conform with the doc and behavior on other platforms: https://github.com/sebhildebrandt/systeminformation/blob/2d5a24068d536cc5e2991108beb6af9eee7edf99/lib/processes.js#L815

sebhildebrandt commented 3 years ago

@GitSquared my fault!! Sorry ... fixed. Version 5.6.18 just released.

GitSquared commented 3 years ago

Np! Thank you for fixing it so quickly :racing_car: