sebhildebrandt / systeminformation

System Information Library for Node.JS
MIT License
2.74k stars 311 forks source link

memLayout return wrong clockSpeed when have two diffenent speed memory #550

Closed xtouching closed 3 years ago

xtouching commented 3 years ago

os: window7 x 64 memory1: Kingston DDR4 2133 MHz memory2: Kingston DDR4 2666 MHz detailed information in the text file, thanks!!! memory.txt

xtouching commented 3 years ago

maybe when _windows in memory.js

clockSpeed: parseInt(util.getValue(lines, 'ConfiguredClockSpeed', '='), 10) || 0,

canbe

clockSpeed: parseInt(util.getValue(lines, 'ConfiguredClockSpeed', '='), 10) || parseInt(util.getValue(lines, 'Speed', '='), 10) || 0 ,

for these special situation?

sebhildebrandt commented 3 years ago

@xtouching actually, catching the second option (testing also speed) makes sense but in your case, both are 2133, so I do not see how to get the 2666 as given in your example ...

xtouching commented 3 years ago

@xtouching actually, catching the second option (testing also speed) makes sense but in your case, both are 2133, so I do not see how to get the 2666 as given in your example ...

yes.....so can we add other param in result as current speed ?

xtouching commented 3 years ago

at least i wanna get the current speed when i get the wrong clockSpeed. or, do we have other method get the clockSpeed both is ok~~~~ thanks~love you~

sebhildebrandt commented 3 years ago

@xtouching will have a look at it tomorrow ...

sebhildebrandt commented 3 years ago

@xtouching should be fixed now. Can you check it on your side? Version 5.7.5. just released,

xtouching commented 3 years ago

@xtouching should be fixed now. Can you check it on your side? Version 5.7.5. just released,

OK,I will check later ,I use version 4.23.5 now. I need to check the changes vs 5.7.5. Thanks so much!!!