Extend peer dependencies to Angular 7 and Angular 8

sebholstein / angular-google-maps

Angular 2+ Google Maps Components

https://angular-maps.com/

MIT License

2.03k stars 815 forks source link

Extend peer dependencies to Angular 7 and Angular 8 #1533

Closed agil-NUBBA closed 5 years ago

agil-NUBBA commented 5 years ago

Issue description

running npm install throws the following warning:

npm WARN @agm/core@1.0.0-beta.5 requires a peer of @angular/common@^5.0.0 || ^6.0.0 but none is installed. You must install peer dependencies yourself.
npm WARN @agm/core@1.0.0-beta.5 requires a peer of @angular/core@^5.0.0 || ^6.0.0 but none is installed. You must install peer dependencies yourself

Steps to reproduce and a minimal demo of the problem

npm install with Angular 7 or Angular 8

Current behavior

npm install shows a couple of warning due to peer dependencies.

Expected/desired behavior

No warnings should be shown

angular2 & angular-google-maps version

@agm/core@1.0.0-beta.5

SlimenTN commented 5 years ago

I'm getting this error too Pls add support for Angular7, there is no big difference between v6 and v7, and you already have support for v6 and make sure to update codelyzer package to 4.5.0 to work with Angular 7 too.

hamzabm commented 5 years ago

Please fix Angular 7 support

eveve86 commented 5 years ago

UnityDev commented 5 years ago

MiguelRozalen commented 5 years ago

mucbits commented 5 years ago

imransilvake commented 5 years ago

I am getting the same message after npm install.

jaysaikia commented 5 years ago

am-trinity commented 5 years ago

+1 up

eelwayadmin commented 5 years ago

+1 up

Dedme commented 5 years ago

+1 up

lazarljubenovic commented 5 years ago

Please use GitHub's upvoting feature instead of pinging everyone by email.

alcfeoh commented 5 years ago

Should definitely support Angular 7. I upvoted, let me know if I can help.

agil-NUBBA commented 5 years ago

https://github.com/SebastianM/angular-google-maps/commit/3728d299534f7e8d47d06ff7897a6d7bc1962ae7 fixes this

SlimenTN commented 5 years ago

@agil-NUBBA so now, should we just update the package ?

alcfeoh commented 5 years ago

@SlimenTN Looks like they still have to release it. I don't see any new release since September last year.

LuckyWraptor commented 5 years ago

Any release ETA?

Kamesh312 commented 5 years ago

Any release ETA?

anantanandgupta commented 5 years ago

when are you planning to release it?

BenjenJones commented 5 years ago

There is a beta.6 changelog since novembre ... when will you release it?

clpalmer commented 5 years ago

Also awaiting the release for this...

SlimenTN commented 5 years ago

Dude angular 8 is already out ...

JosepAlacid commented 5 years ago

Until then... https://github.com/agm-preview/angular-google-maps

DaSchTour commented 5 years ago

I started a new project to improve overall project structure and improve release cycles. It's not ready yet. I just released a 0.0.1 at @ng-maps/core that includes the most important party. Everybody is invited to help and contribute at https://github.com/ng-maps/ng-maps

alvaro-octal commented 5 years ago

Why not asking for ownership / permission on NPM? @DaSchTour, at this point I guess if fully reasonable

DaSchTour commented 5 years ago

As I guess this project is dead and there is a lot to change and I guess a fresh start with an organization is a much cleaner way for a more sustainable future for such a library.

JosepAlacid commented 5 years ago

Well I supose this is what you will find at https://github.com/agm-preview/angular-google-maps I can't evaluate how this will evolve in the future, but this repository is actually compatible with Angular 7.

schankam commented 5 years ago

Same issue with Angular 8 now

ghost commented 5 years ago

done

msalmankarim commented 5 years ago

Facing this same issue while upgrading from angular 7 to 8

clpalmer commented 5 years ago

@msalmankarim this is already resolved, as per the closed status. Use beta6.

jwcurnalia commented 5 years ago

This is not resolved

ghost commented 5 years ago

@jwcurnalia notice how it doesn't say that @agm/core has an incompatible dependency, but @ng-idle/core. Your problem is not caused or related to our library.

jwcurnalia commented 5 years ago

I apologize. I had read the error a couple of times trying to get the upgrade to work. I'm sorry I wasted your time