include binding.gyp, explicitly build native

jbcpollak commented 1 year ago

this does three things:

include binding.gyp in the package - my mistake and should have been included originally
makes node-gyp an explicit dependency, so package consumers can compile locally w/o needing to depend on it themselves
makes building the native code an explicit step during installation - this is optional, as the inclusion of binding.gyp makes it implicit, but this seems safer.

I am using yarn on my downstream project and don't seem to understand how to force yarn to update local packages, but I created an empty npm package that depends on the local pack of this branch and the install correctly built the build/ directory.

I will need to test actually functionality over the canbus later, hopefully this evening (EST)

sebi2k1 commented 1 year ago

I fixed an issue in npmpublish.yml to cal build:ts correctly.

sebi2k1 commented 1 year ago

if you do "npm ci" and then "npm pack", you should get a nom install-able package. I still struggle to get my local container up and running.

jbcpollak commented 1 year ago

hello, just wanted to comment that I've finally been able to test this on my project over vcan0 using an locally built .tgz using npm pack on your main branch. Everything seems fine as far as I can seen.

I apologize for the delay, I was in the middle of a refactor of my own project and it took longer than I expected for that to stabilize before I could test.

I think it is safe to push a new version to npmjs.com, perhaps as 4.0.0-rc1?

sebi2k1 commented 1 year ago

Thanks Josh. I am working on getting my npm account up again.

sebi2k1 commented 1 year ago

Published. Thanks for your effort, Josh!

jbcpollak commented 1 year ago

yay! Thanks for merging it!

sebi2k1 / node-can

include binding.gyp, explicitly build native #109