sebin0817 / pe

0 stars 0 forks source link

Invalid address accepted #10

Open sebin0817 opened 2 months ago

sebin0817 commented 2 months ago

Screenshot 2024-04-19 at 4.54.36 PM.png

Screenshot 2024-04-19 at 4.55.17 PM.png

Tested: edit 8 a/123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567 Expected: Raise an error that a valid address should be keyed in (e.g., Textual address instead of a purely numerous one) Actual: Accepted the invalid address and the PersonCard is confusing as phone number is placed right before the address, user would not be able to know which is an address portion

nus-pe-bot commented 2 months ago

[IMPORTANT!: Please do not edit or reply to this comment using the GitHub UI. You can respond to it using CATcher during the next phase of the PE]

Team's Response

Thank you for reporting this bug.

Our team feels that this is a feature flaw rather than a functionality bug, our UG states that address can contain alphanumeric characters therefore it is expected that a address with pure numeric input would be allowed: Screenshot 2024-04-21 at 14.43.58.png

Our team's opinion is that adding a validity check for address does not bring much value to the user since this only matters when there is a typo by the user, which they can easily fix using the edit command. However we do foresee implementing a address validity check causing potential problems to users with contacts that have address with just postal codes e.g. 623234. Therefore, our team will consider this response.NotInScope due to the value/effort considerations.

Items for the Tester to Verify

:question: Issue response

Team chose [response.NotInScope]

Reason for disagreement: [replace this with your reason]


## :question: Issue type Team chose [`type.FeatureFlaw`] Originally [`type.FunctionalityBug`] - [ ] I disagree **Reason for disagreement:** [replace this with your reason]
## :question: Issue severity Team chose [`severity.Low`] Originally [`severity.Medium`] - [ ] I disagree **Reason for disagreement:** [replace this with your reason]