search

sebin0817 / pe

0 stars 0 forks source link

Invalid name accepted #13

Open sebin0817 opened 2 months ago

sebin0817 commented 2 months ago

Screenshot 2024-04-19 at 5.07.31 PM.png

Tested: edit 6 n/123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567

Justification: Pure numeric input should not be considered as a valid name input. This is against the standard norm

nus-se-bot commented 2 months ago

[IMPORTANT!: Please do not edit or reply to this comment using the GitHub UI. You can respond to it using CATcher during the next phase of the PE]

Team's Response

Thank you for reporting this bug.

Our team feels that this is a feature flaw rather than a functionality bug, our UG states that names can contain alphanumeric characters therefore it is expected that a name with pure numeric input would be allowed: Screenshot 2024-04-21 at 14.16.52.png

Our team's opinion is that adding a validity check for name does not bring much value to the user since this only matters when there is a typo by the user, which they can easily fix using the edit command. However we do foresee implementing a name validity check causing potential problems to users with contacts that have names with unexpected format for example X Æ A-12. We have a planned enhancement to address this name issue as shown below. Therefore, our team will consider this response.NotInScope due to the value/effort considerations. Screenshot 2024-04-21 at 14.26.10.png

Items for the Tester to Verify

:question: Issue response

Team chose [response.NotInScope]

Reason for disagreement: [replace this with your reason]

## :question: Issue type Team chose [`type.FeatureFlaw`] Originally [`type.FunctionalityBug`] - [ ] I disagree **Reason for disagreement:** [replace this with your reason]