search

sebin0817 / pe

0 stars 0 forks source link

Messy UML diagram for `Ui.java` #17

Open sebin0817 opened 2 months ago

sebin0817 commented 2 months ago

image.png

PersonCard should be directly below PersonListPanel and not MeetingCard. The current diagram is confusing

nus-pe-bot commented 2 months ago

[IMPORTANT!: Please do not edit or reply to this comment using the GitHub UI. You can respond to it using CATcher during the next phase of the PE]

Team's Response

Thank you for the bug report.

However, according to the PE specifications, the possible bugs for UML diagrams are as follows:

image.png

We felt that the diagram is not overly complicated and even when PersonCard is not directly below PersonListPanel, the arrow still shows a correct respective association that is still direct and clear to see. As we are also using PlantUML, adding PersonCard under PersonListPanel causes the diagram to make it harder to see the association to Model which is arguably worse.

image.png

Hence, as the report does not seem to violate any of the PE specified bug reports, we feel that the bug report should be invalid.

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: [replace this with your reason]

## :question: Issue severity Team chose [`severity.VeryLow`] Originally [`severity.Low`] - [ ] I disagree **Reason for disagreement:** [replace this with your reason]