Open sebin0817 opened 2 months ago
[IMPORTANT!: Please do not edit or reply to this comment using the GitHub UI. You can respond to it using CATcher during the next phase of the PE]
Thank you for reporting this issue!
Our team made a deliberate design choice to not throw an error if the exact same value is provided.
There are two possible scenarios when a user enters the same value for a field:
For case 1, not throwing an error would be more convenient because if we threw an error the user would have to edit the command to remove that field and re-run the command which would effectively do the same thing.
For case 2, not throwing an error would cause a typo to not be caught, which is not ideal, however we think this is a worthy trade-off for the convenience in case 1.
We are open to implementing this feature if the majority of our users prefer for this behaviour, however our current opinions is not throwing an error gives a better user experience. Therefore we mark this as NotInScope
.
Team chose [response.NotInScope
]
Reason for disagreement: [replace this with your reason]
Tested:
edit 9 n/Test2
when initial name was Test2 Expected: Raise an error that the same name value was given Actual: Accepted the edit command, confusing for users