search

sebleedelisle / ofxLaser

An openFrameworks addon for controlling multiple lasers.
Mozilla Public License 2.0
258 stars 32 forks source link

some updates #42

Closed dimitre closed 11 months ago

dimitre commented 11 months ago

Hello @sebleedelisle I'm submitting some suggestions of change to make it run on macOS. most of them related to the recent removal of using namespace std; I'm still having one issue with ofParameter guideImageColour I'm trying to make it compile here to investigate projectGenerator issues. Thanks

sebleedelisle commented 11 months ago

Hi Dimitre, thanks so much for this, although I worry that it may have been wasted, the dev branch is compiling for me with nightly, the main branch is a little out of date so I need to move the dev branch over some time soon.

You wanna test the dev branch?

thanks!

Seb

dimitre commented 11 months ago

Thanks, I've tested and it doesn't compile here. maybe ofxImGui should be updated

sebleedelisle commented 11 months ago

ah strange, mine seems to be compiling on OSX at least. I'll make sure I have a clean download and try again.

On Sun, 3 Dec 2023 at 00:19, Dimitre @.***> wrote:

Thanks, I've tested and it doesn't compile here. maybe ofxImGui should be updated

— Reply to this email directly, view it on GitHub https://github.com/sebleedelisle/ofxLaser/pull/42#issuecomment-1837289743, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAA3CEXTUSHA2WVJXTB7T73YHPARVAVCNFSM6AAAAABAEGAUZGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQMZXGI4DSNZUGM . You are receiving this because you were mentioned.Message ID: @.***>

sebleedelisle commented 11 months ago

OK I've merged this into main, and made some other minor changes, main now compiles in a relatively recent nightly on OSX. Thanks for your help with this!