search

seblindfors / Immersion

Immersive questing addon for World of Warcraft
Artistic License 2.0
26 stars 15 forks source link

Add gossip text sort option #29

Closed Sookhaal closed 1 year ago

Sookhaal commented 1 year ago

Hi, Gossip options are not sorted like in the default Blizzard UI. It's quite annoying when you're doing a dungeon like Azure Vault, wipe then having to use the portals. Your group tells you to use the last gossip option to get to the correct place but the last option on their screen (without immersion) is not the same as yours (with immersion).

This PR adds an option to set a gossip sort to either None (immersion's current behavior and this PR's default value) or Blizzard (using GossipOptionSort function which uses the orderIndex value of the gossip info).

I chose a select option in case you want to add other sorting options later.

Sookhaal commented 1 year ago

Immersion's current behavior: before

PR with sort option set to Blizzard: after

Vanilla UI options: blizzard

jetersen commented 1 year ago

@seblindfors this would be really useful. Though I wonder if this even needs to be an option. Should this not be the default behavior?

jetersen commented 1 year ago

Ah this seems to be fixed in https://github.com/seblindfors/Immersion/commit/262d5679fe30bac740a768a4f8b1a1812c33f446

Sookhaal commented 1 year ago

Yep, looks like it's fixed, closing.