search

seblindfors / Immersion

Immersive questing addon for World of Warcraft
Artistic License 2.0
26 stars 15 forks source link

Fix skill point rewards #43

Closed Witnesscm closed 2 weeks ago

Witnesscm commented 2 months ago

pic1

This API only return the first value, so the skill point rewards is not displayed correctly.

Witnesscm commented 2 months ago

pic2

And fixed greeting quest title icon.

seblindfors commented 2 weeks ago

Thank you for the contributions. By "cleanup old APIs", I assume this is tested across all 3 clients?

Witnesscm commented 2 weeks ago

Oops, it seems there's an error in the Classic client. I will recheck the code.

seblindfors commented 2 weeks ago

I will do some confirmation testing to see that everything is good before releasing, but this was a much needed cleanup. The offset refactoring across the 3 clients has been a real pain in the ass to keep up with. Thank you very much.

seblindfors commented 2 weeks ago

Oops, it seems there's an error in the Classic client. I will recheck the code.

There was an error in API:GetAccountCompleted that has been fixed on master.