search

seblj / roslyn.nvim

Roslyn LSP plugin for neovim
MIT License
98 stars 8 forks source link

Allow bringing your own LSP command #14

Closed tarantoj closed 1 month ago

tarantoj commented 2 months ago

I use nix, which has Microsoft.CodeAnalysis.LanguageServer packaged up in roslyn-ls, which I have installed on my system.

This plugin expects a dll to exist on the filesystem https://github.com/seblj/roslyn.nvim/blob/76d4ddb8b5ec800c5d129c0bee5ab0d5ae8fff7f/lua/roslyn/init.lua#L206 and to execute the lsp with dotnet https://github.com/seblj/roslyn.nvim/blob/76d4ddb8b5ec800c5d129c0bee5ab0d5ae8fff7f/lua/roslyn/init.lua#L73

in my case, I only need to execute Microsoft.CodeAnalysis.LanguageServer https://github.com/tarantoj/kickstart-nix.nvim/blob/480334c0b0120b74a40f29564d1d98a879039a6f/nvim/lua/roslyn/init.lua#L71-L74

Wondering if you'd be okay with supporting this usecase? Happy to open a PR if you are (not exactly sure how I'd keep it backward compatible just yet though...)

seblj commented 2 months ago

Yes that would be nice! I am also not sure how it should be done though. We should try to find a reasonable solution for it, but if not, I am open to a breaking change of the user needing to include dotnet in the exe configuration. However, we should try to see if there is another way first

tarantoj commented 2 months ago

Sick, I'll look into it!