search

seblucas / cops

Calibre OPDS (and HTML) PHP Server : web-based light alternative to Calibre content server / Calibre2OPDS to serve ebooks (epub, mobi, pdf, ...)
http://blog.slucas.fr/en/oss/calibre-opds-php-server
GNU General Public License v2.0
1.43k stars 229 forks source link

Fix for koreader #315

Closed leolivier closed 7 years ago

leolivier commented 7 years ago

Hi, Had a bug using cops with koreader Fixed it by adding: if ($qid == null) $qid=getURLParam ("amp;id"); at line 25 in feed.php Sorry, I can't tell you anymore what the bug was as I uninstalled koreader a while ago. I re discovered this fix when doing a diff between my version (based on 1.0.0RC4) and the 1.0.1 version to see what had changed.

seblucas commented 7 years ago

Hi

Your fix feels weird, it would mean that Koreader does not urldecode the URL coming from the OPDS feed. That would be strange (= a big problem in Koreader OPDS client code).

When did you last saw this bug ?

leolivier commented 7 years ago

Hi Seb I fixée this un July, I think. Sorry I didn't créateur an issue for this on github attention that time... But indeed, koreader dis not work with opds without that fix...

seblucas commented 7 years ago

Thanks, I'll test.

Offtopic : French auto complete in English is a PITA :(

seblucas commented 7 years ago

@leolivier

This should be a bug in Koreader, let's see what they say about it.

leolivier commented 7 years ago

Great ! Offtopic: sorry for the auto complète, yes, a real PITA :) I'll disable it one day

seblucas commented 7 years ago

Seems fixed by this commit