Feature: Change monocle to epub.js

seblucas / cops

Calibre OPDS (and HTML) PHP Server : web-based light alternative to Calibre content server / Calibre2OPDS to serve ebooks (epub, mobi, pdf, ...)

http://blog.slucas.fr/en/oss/calibre-opds-php-server

GNU General Public License v2.0

1.43k stars 229 forks source link

Feature: Change monocle to epub.js #459

Open s-fiebig opened 5 years ago

s-fiebig commented 5 years ago

The monocle package is currently not developed anymore and I don't know of any "serious" fork continuing work. epub.js (https://github.com/futurepress/epub.js) seems like a good choice to allow in-browser reading, which is still actively developed. In addition, the current monocle reader is not a good choice for reading graphical novels, e.g. comics or mangas, with full page images. In my cases, the images render offscreen and scrolling is not even possible. Instead of fixing this issue in monocle, I've implemented epub.js locally for testing purposes and it looks very promising.

Would there be any interest to include a pull request using a epub.js. In this case I'd rework my local prototype and create some setting to switch between both readers.

horus68 commented 5 years ago

I would love to see that implemented, even if as a switch function

s-fiebig commented 5 years ago

That's great to know! I'm preparing a pull request, so that somebody can have a look what features of epub.js should be included in addition. The sample reader https://github.com/futurepress/epubjs-reader does not implement all the nice features that are possible.

horus68 commented 5 years ago

@seblucas @marioscube

seblucas commented 5 years ago

@s-fiebig please send a PR, it's on my todo list for a while ;)

s-fiebig commented 5 years ago

I haven't forgotten about this issue ;-). But some personal life issues came up that made it impossible to work on it for the last two weeks. But maybe I can talk about some of my last items I wanted to resolve for the PR:

I'm not sure what to do about localization for the single setting item I introduced. I can add German and English with confidence. What to do about the others? Machine translation and somebody improves it later?
The current fullscreen mode for epub.js reader project (this is unrelated to the epub.js library itself) does not work correctly. Especially mobile devices have "problems" with fullscreen mode. I wanted to have a solution for this.
In addition, the features font size and continuous scrolling have been on my wishlist for a first version.

horus68 commented 5 years ago

For the translations: you create the English file on your PR. Than i will upload that file to the Transifex Translations system here: http://www.transifex.com/rberec/cops From there COPS users can translate it to their languages. I will then submit the translations into a new PR to Cops github just for the translations done.

seblucas commented 5 years ago

@s-fiebig No rush take all the time you need, still if you want to make an early PR, please do it so it will be easier for others to help/test

mikespub commented 6 months ago

Included in release 2.5.4+ at https://github.com/mikespub-org/seblucas-cops