search

seboettg / citeproc-php

Full-featured CSL 1.0.1 processor for PHP
MIT License
73 stars 38 forks source link

Add possibility to include affixes in lambda functions, Issue #100 #103

Closed nongenti closed 2 years ago

nongenti commented 3 years ago

A solution to include affixes in lambda funcitons. If you want to include affixes, change the $additionalMarkup array like this: 

$additionalMarkup = [
    'title' => array(
        'function' => $titleFunction,
        'affixes' => TRUE),
    'author' => array(
        'function' => $authorFunction,
        'affixes' => TRUE)
];

If you set 'affixes' => FALSE or use the previous syntax, then it works as before.

seboettg commented 2 years ago

Hello @nongenti! Thank you for this PR! I have some code additions I'd like to discuss in this PR, but for that I need PUSH access to the PR. You have to add priviliges for that. More information on https://docs.github.com/en/github/collaborating-with-pull-requests/working-with-forks/allowing-changes-to-a-pull-request-branch-created-from-a-fork Thank you!

nongenti commented 2 years ago

Hallo @seboettg! Sorry, I don't have the option "Allow edits from maintainers", because it's a organization-owned fork and not a user-owned fork. Do you know another possibility?

seboettg commented 2 years ago

@nongenti No idea. Maybe the organization admin can change this?

nils-stefan-weiher commented 2 years ago

Hi @seboettg ,

I tried to change it. But could not find any setting, which applies to this.

seboettg commented 2 years ago

Unfortunately, I'm also not familiar with that... Did you follow the instructions on https://docs.github.com/en/github/collaborating-with-pull-requests/working-with-forks/allowing-changes-to-a-pull-request-branch-created-from-a-fork#enabling-repository-maintainer-permissions-on-existing-pull-requests

nils-stefan-weiher commented 2 years ago

Yes, sadely the checkbox is not available.

seboettg commented 2 years ago

Ok, I would suggest to create a new PR.

Bildschirmfoto vom 2021-09-20 17-20-18 Bildschirmfoto vom 2021-09-20 17-20-39

I think it's necessary to make your changes in a separate branch, since it's not possible for others to make write operations in the master branch

seboettg commented 2 years ago

Hello @nongenti and @isgrim!

To summarize all necessary steps:

  1. create a new branch in the forked repo containing your changes
  2. create a new pull request and select the forked repo and the new branch as head
  3. select the "seboettg/citeproc-php" and the master branch as base
  4. select "Allow edits by maintainers"
  5. add title and description for your PR
  6. submit the pull request

Then, with the new PR I'm able to commit changes and it is much easier to discuss.

I'm going to close this PR now.