Closed jonathangreen closed 6 years ago
Hey Jonathan! Thank you for this detailed issue description. I guess I could fix it. Please checkout branch issue-50 for a test.
This is awesome @seboettg thank you. I will test out later today and let you know the results.
I also want to thank you for maintaining citeproc-php and moving development forward. It is great to see the library maintained again. I'm a developer on the islandora project, and I have a pull request (https://github.com/Islandora/islandora_scholar/pull/291) in progress to replace our fork of citeproc v1 with your version of citeproc. Thought you might like to see where the library is being used.
Just gave the issue-50
branch a test, and it does fix my problem. Thank you again!
Ok, perfect. I'm happy to hear that citeproc-php is useful for so many different projects. I started reimplementation of citeproc-php for a previous project of mine, and the old version ran into a lot of painful problems, that wasn't easy to fix. The new version follows the approach of test-driven development and makes it much easier to fix issues.
By the way: I'm going to create further test cases before I make the next release.
Cool. Thanks @seboettg. Can you update this ticket when you do the next release, so I know when to pull it into my project? Do you know when you'll be adding the additional test cases?
Hello.
This issue came up while testing
citeproc-php
with the MLA style found here: https://github.com/citation-style-language/styles/blob/master/modern-language-association.cslThis test case reproduces the issue:
Running the test I get:
It does however pass when running the same test case against
citeproc-js
.