Guard against unset variable

seboettg / citeproc-php

Full-featured CSL 1.0.1 processor for PHP

MIT License

75 stars 39 forks source link

Guard against unset variable #53

Closed jonathonwalz closed 6 years ago

jonathonwalz commented 6 years ago

Ensure that if evaluateStringPluralism is called with an unset variable key PHP doesn't emit any notices.

I'm not 100% sure if this is the correct fix or if the calling code (Label::getPlural) should be adjusted. I've only seen this happen with editortranslator which I believe is a special key.

coveralls commented 6 years ago

Coverage decreased (-0.1%) to 91.978% when pulling 354f7a0a039da88c17b254c26a117a75b2f0620d on umn-ici:fix-notice into 8063510c7f2065bf311bfc36bf12054d9d8d21b7 on seboettg:master.

jonathonwalz commented 6 years ago

Tests are failing due to the es language override recently added to the APA styles. Pull request #52 is a potential fix to the issue.

seboettg commented 6 years ago

okay, I could push an own commit to your PR 👍 In "getPlural" I have added another "isset" on editor to the inserted "isset" from you.