search

seboettg / citeproc-php

Full-featured CSL 1.0.1 processor for PHP
MIT License
75 stars 39 forks source link

Add loading of primary dialect #54

Closed jonathonwalz closed 6 years ago

jonathonwalz commented 6 years ago

By using the locales.json file that is provided by the locales repository, we can automatically pick a default dialect when none is provided. This allows consuming code to simply specify en for $langKey and en-US will automatically be picked.

coveralls commented 6 years ago

Coverage Status

Coverage decreased (-0.2%) to 91.921% when pulling 63f4bbdc3fff0c8d027380f95aa442dd47a5d134 on umn-ici:locale-loading into 8063510c7f2065bf311bfc36bf12054d9d8d21b7 on seboettg:master.

coveralls commented 6 years ago

Coverage Status

Coverage decreased (-0.2%) to 91.921% when pulling 26cb6a32ae0a106470c8a858dad957d6d02d643b on umn-ici:locale-loading into 8063510c7f2065bf311bfc36bf12054d9d8d21b7 on seboettg:master.

seboettg commented 6 years ago

Thank you for these great improvements. I've made some refactorings but unfortunately am not able to push it to the regarding branch on umn-ici/citeproc-php.

The following error message appears:

ERROR: Permission to umn-ici/citeproc-php.git denied to seboettg.
fatal: Could not read from remote repository.

same problem with the other PRs of you. Maybe an issue with wrong rights?

(Of course, I can push it to my repo, but then my additions will not appear in the PR, so we can not discuss about it.)

jonathonwalz commented 6 years ago

I've added you as a collaborator to the umn-ici/citeproc-php repo, so you should hopefully have rights now. (No idea why the "Allow edits from maintainers" option wasn't working)

seboettg commented 6 years ago

It still doesn't work... really strange. I will have a closer look tomorrow.

seboettg commented 6 years ago

Do you have any restrictions for branches locale-loading and fix-style-locale?

seboettg commented 6 years ago

Did you allow edit from maintainers, as described hier: https://help.github.com/articles/allowing-changes-to-a-pull-request-branch-created-from-a-fork/?