Closed jonathonwalz closed 6 years ago
Thank you for these great improvements. I've made some refactorings but unfortunately am not able to push it to the regarding branch on umn-ici/citeproc-php.
The following error message appears:
ERROR: Permission to umn-ici/citeproc-php.git denied to seboettg.
fatal: Could not read from remote repository.
same problem with the other PRs of you. Maybe an issue with wrong rights?
(Of course, I can push it to my repo, but then my additions will not appear in the PR, so we can not discuss about it.)
I've added you as a collaborator to the umn-ici/citeproc-php
repo, so you should hopefully have rights now. (No idea why the "Allow edits from maintainers" option wasn't working)
It still doesn't work... really strange. I will have a closer look tomorrow.
Do you have any restrictions for branches locale-loading and fix-style-locale?
Did you allow edit from maintainers, as described hier: https://help.github.com/articles/allowing-changes-to-a-pull-request-branch-created-from-a-fork/?
By using the
locales.json
file that is provided by the locales repository, we can automatically pick a default dialect when none is provided. This allows consuming code to simply specifyen
for$langKey
anden-US
will automatically be picked.