search

seboettg / citeproc-php

Full-featured CSL 1.0.1 processor for PHP
MIT License
75 stars 39 forks source link

Use "applyAdditionalMarkupFunction" for all fields #55

Closed todoricMDPI closed 5 years ago

todoricMDPI commented 6 years ago

All field who don't use "variable" renderType don't use "AdditionalMarkup" (for example "issued"). This commit fix that all renderType use "AdditionalMarkup" function.

coveralls commented 6 years ago

Coverage Status

Coverage remained the same at 91.978% when pulling 3245a8429876c44da85dadc4cf5d312d72fd0c99 on todoricMDPI:master into a618e139d04ee78075b6da0393b2a15cf77a7196 on seboettg:master.

seboettg commented 6 years ago

Thanks for this PR! Unfortunately, due to your changes some tests are failing. For instance: As you can see here the <a>-tag has been rendered twice. 

[<a id="item-1" href="#item-1"><a id="item-1" href="#item-1">1</a></a>]